Change in vdsm[master]: spec: split qemu-kvm* requirement to its own %if

Federico Simoncelli fsimonce at redhat.com
Fri Sep 26 10:56:56 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: spec: split qemu-kvm* requirement to its own %if
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

+1 because we're on rush, but I'd like to have the layout ready for future changes.

http://gerrit.ovirt.org/#/c/33378/1/vdsm.spec.in
File vdsm.spec.in:

Line 225: Requires: qemu-img-rhev >= 2:0.12.1.2-2.415.el6_5.3
Line 226: %else
Line 227: Requires: qemu-kvm >= 2:0.15.0-4
Line 228: Requires: qemu-img >= 2:0.15.0-4
Line 229: %endif
I think rhel7 will split soon with the new requirements and since we're preparing the layout for the future changes (and who's coming after us may have less attention), we could maintain the old behavior.

 %if 0%{?rhel}
 %if 0%{?rhel} >= 7
 ...
 %else
 ...
 %endif
 %else
 ...
 %endif
Line 230: 
Line 231: # GlusterFS client-side RPMs needed for Gluster SD
Line 232: %if 0%{?with_gluster}
Line 233: Requires: glusterfs >= 3.4.2


-- 
To view, visit http://gerrit.ovirt.org/33378
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I088eee894b631d9f864d6b7563877bf3ac76a9f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list