Change in vdsm[master]: spec: split qemu-kvm* requirement to its own %if

danken at redhat.com danken at redhat.com
Thu Sep 25 21:50:34 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: spec: split qemu-kvm* requirement to its own %if
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33378/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: qemu-kvm* dependency is about to become even more complex, and as such
Line 10: it is granted a special %if section. One of the three occurences of
Line 11: qemu-kvm-rhev can be dropped, since el6's current requirement equally
Line 12: applies to el7.
> Can you explain in the commit message why we did not require specific versi
I'm not sure which explanation you are looking for. We had no el7-specific requirement for qemu-kvm, simply because we did not test it enought and never found a bug in el7'd qemu. I assume you are looking for something more profound.

Since el7.0 ships qemu-kvm > version-required-by-el6, copying the requirement to el7 harms no one, and makes the condition simpler.

It's very sad that a bug was fixed in el6 before fixing it in el7. But I don't see how this is related to us (apart of out need to test el7 more).
Line 13: 
Line 14: Change-Id: I088eee894b631d9f864d6b7563877bf3ac76a9f3


-- 
To view, visit http://gerrit.ovirt.org/33378
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I088eee894b631d9f864d6b7563877bf3ac76a9f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list