Change in vdsm[master]: image: use qemu-img convert to copy internal volumes

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 25 20:05:20 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33355/1//COMMIT_MSG
Commit Message:

Line 22: - copying images from block domains we won't copy the entire chunk
Line 23:   (1Gb) but only the amount of data really in use
Line 24: 
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
The downside is insignificant - we can remove this sentence from the commit message.

The real downside is this can breaks everything if qemu-img convert with backing file is buggy - we never used this option - right?
Line 27: 
Line 28: Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list