Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync
danken at redhat.com
danken at redhat.com
Thu Sep 25 18:19:52 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32695/6/vdsm/API.py
File vdsm/API.py:
Line 1221: if utils.tobool(secure):
Line 1222: inp += 'secure=yes\n'
Line 1223: inp += options
Line 1224:
Line 1225: ret = None
Why would we ever want to return None? This function must always return a {'status':bla}.
I prefer bailing out early with "return", but I know that there are conflicting religions out there. But in this patch, would you not mix between the two? This patch should be about calling fence() in sync; not about refactoring these long conditions. I think it's safer to do.
Line 1226: try:
Line 1227: rc, out, err = fence(script, inp)
Line 1228: except OSError as e:
Line 1229: if e.errno == os.errno.ENOENT:
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list