Change in vdsm[master]: netinfo: improve which ipv4 addr is reported if there are mu...

asegurap at redhat.com asegurap at redhat.com
Thu Sep 25 16:14:58 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: improve which ipv4 addr is reported if there are multiple primary
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33375/1//COMMIT_MSG
Commit Message:

Line 13: 
Line 14: The improvement is that now we will check if any of the addresses is
Line 15: in the subnet of the gateway and report one of them. If there is no
Line 16: default gw in the main table for the device we return the last
Line 17: set primary ip and if there is a default gw but going through another
Zordrak suggests that if there is no default gw in the main table for the device we should also return the first ipv4 address we get from netlink.
Line 18: hop, we return the first set ip.
Line 19: 
Line 20: Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893


-- 
To view, visit http://gerrit.ovirt.org/33375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list