Change in vdsm[master]: gluster: Temporary fix for supervdsm memory leak.

asegurap at redhat.com asegurap at redhat.com
Thu Sep 25 13:04:35 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: gluster: Temporary fix for supervdsm memory leak.
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.ovirt.org/#/c/33312/3/vdsm/gluster/gfapi.py
File vdsm/gluster/gfapi.py:

Line 26: 
Line 27: import exception as ge
Line 28: from vdsm import constants
Line 29: from vdsm import utils
Line 30: from __init__ import makePublic
> It's sad that we have to use this
This is not really necessary. here continue to have 

    from . import makePublic
Line 31: 
Line 32: 
Line 33: GLUSTER_VOL_PROTOCAL = 'tcp'
Line 34: GLUSTER_VOL_HOST = 'localhost'


Line 147: # This can be reverted back once the memory leak issue
Line 148: # is fixed in libgfapi.
Line 149: @makePublic
Line 150: def volumeStatvfs(volumeName):
Line 151:     script = constants.P_VDSM_GLUSTER + "gfapi.pyc"
instead of script have:

    module = gluster.gfapi
Line 152:     command = [constants.EXT_PYTHON, script, "-v", volumeName]
Line 153:     rc, out, err = utils.execCmd(command)
Line 154:     if rc != 0:
Line 155:         raise ge.GlfsStatvfsException(rc, out, err)


Line 148: # is fixed in libgfapi.
Line 149: @makePublic
Line 150: def volumeStatvfs(volumeName):
Line 151:     script = constants.P_VDSM_GLUSTER + "gfapi.pyc"
Line 152:     command = [constants.EXT_PYTHON, script, "-v", volumeName]
Here:

    command = [constants.EXT_PYTHON, '-m', module, '-v', volumeName]
Line 153:     rc, out, err = utils.execCmd(command)
Line 154:     if rc != 0:
Line 155:         raise ge.GlfsStatvfsException(rc, out, err)
Line 156:     json_acceptable_string = out[0].replace("'", "\"")


Line 183:     args = parser.parse_args()
Line 184:     return args
Line 185: 
Line 186: 
Line 187: if __name__ == '__main__':
This will get executed by the python interpreter when putting -m and pointing it to this module of the gluster package (the package must be in the path, of course)
Line 188:     args = parse_cmdargs()
Line 189:     try:
Line 190:         res = volumeStatvfsGet(args.volume, args.host,
Line 191:                                args.port, args.protocol)


-- 
To view, visit http://gerrit.ovirt.org/33312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7079426178ce47008d9a3b83635afce98536ca34
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list