Change in vdsm[master]: netinfo: Stop NetworkManager from ifup'ing our reference bond

danken at redhat.com danken at redhat.com
Thu Sep 25 11:35:21 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Stop NetworkManager from ifup'ing our reference bond
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33227/4/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 428:     if has_nm:
Line 429:         nmcli = _NM_CLI_BINARY.cmd
Line 430:         ifcfgPath = NET_CONF_PREF + interface
Line 431:         execCmd([_TEE_BINARY.cmd, ifcfgPath], sudo=True,
Line 432:                 data='DEVICE=%s\nNM_CONTROLLED=no\n' % interface)
Since this becomes so complex, and since you report that

 [Bug 1063282] [abrt] NetworkManager: nm_device_remove_pending_action(): NetworkManager killed by SIGSEGV

can ridden this code path, I'd rather not place this code in vdsm per se.

Please move the bonding-defaults-extraction into a vdsm-tool command. _getAllDefaultBondingOptions() should do only a json.load(open('/var/lib/vdsm/bonding-defaults')).
Line 433: 
Line 434:         rc, _, _ = execCmd([nmcli, 'conn', 'load', ifcfgPath], sudo=True)
Line 435:         if rc:
Line 436:             raise RuntimeError('Failed to unmanage %s.' % interface)


-- 
To view, visit http://gerrit.ovirt.org/33227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff14c4791355f05890805a8d6b5208e7adb0ef7b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list