Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Federico Simoncelli
fsimonce at redhat.com
Thu Sep 25 07:37:31 UTC 2014
Federico Simoncelli has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33349/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 144: """
Line 145: try:
Line 146: flag = {"create": "-f", "convert": "-O", "ammend": "-f"}[command]
Line 147: except KeyError:
Line 148: return False
This is something highly unexpected maybe it's better to fail hard.
Line 149:
Line 150: cmd = [_qemuimg.cmd, command, flag, FORMAT.QCOW2, "-o", "?", "/dev/null"]
Line 151:
Line 152: rc, out, err = utils.execCmd(cmd, raw=True)
--
To view, visit http://gerrit.ovirt.org/33349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list