Change in vdsm[master]: netinfo: Error out if we failed to change a bond's mode
osvoboda at redhat.com
osvoboda at redhat.com
Wed Sep 24 20:56:04 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Error out if we failed to change a bond's mode
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32657/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 434: mode = str(mode)
Line 435: rc, _, err = execCmd([teeCmd, BONDING_OPT % (bondName, 'mode')],
Line 436: data=mode, sudo=True)
Line 437: if rc:
Line 438: raise RuntimeError('Changing a bond\'s mode failed, is '
> better:
How about our well-known "reference bond"? :-)
Line 439: 'NetworkManager running?', '\n'.join(err))
Line 440:
Line 441: # only read non-empty options
Line 442: opts[mode] = dict(((opt, val) for (opt, val) in
--
To view, visit http://gerrit.ovirt.org/32657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c29bd5aee13cd6f0be1ab7f308b5432f264215c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list