Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Federico Simoncelli
fsimonce at redhat.com
Wed Sep 24 12:40:08 UTC 2014
Federico Simoncelli has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33304/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 187: cmd.append(srcImage)
Line 188:
Line 189: if dstFormat:
Line 190: cmd.extend(("-O", dstFormat))
Line 191: if dstFormat == FORMAT.QCOW2 and _supports_qcow2_compat():
> I checked and found that if you do not specify an output_format (-O), you w
Dan the point of this patch is indeed to make sure that the destination compat is 0.10 even when srcImage is 0.10.
It was discussed here:
https://bugzilla.redhat.com/show_bug.cgi?id=1139707#c26
"The rule of thumb is that anything that creates a new image gets the same
defaults as qemu-img create."
So even if by accident now it's using the compat of srcImage we don't want to rely on this glitch.
Line 192: cmd.extend(('-o', 'compat=' + QCOW2_COMPAT))
Line 193:
Line 194: cmd.append(dstImage)
Line 195:
--
To view, visit http://gerrit.ovirt.org/33304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae86a007c3822e0523caff66473581182810c74c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list