Change in vdsm[ovirt-3.4]: netinfo: do not report broken networks

asegurap at redhat.com asegurap at redhat.com
Wed Sep 24 12:04:09 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: do not report broken networks
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33320/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 559:             continue  # Do not report missing libvirt networks.
Line 560:         except IOError:
Line 561:             continue  # Do not report broken networks.
Line 562: 
Line 563:     for dev in (link for link in getLinks() if not link.isHidden()):
If I'm not mistaken, both in ovirt-3.4 and now in master, the error that could happen with a device disappearing during netinfo, it would be raised in this for block.

It is bothering, but you should catch it here and then find which network above had it as backing device (probably having that mapping in a dict) and pop out from d['networks'] the broken net.
Line 564:         if dev.isBRIDGE():
Line 565:             d['bridges'][dev.name] = \
Line 566:                 _bridgeinfo(dev.name, gateways, ipv6routes)
Line 567:         elif dev.isNICLike():


-- 
To view, visit http://gerrit.ovirt.org/33320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa9173cb65d5140951c38d0cf1e49eb93222903
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list