Change in vdsm[ovirt-3.4]: netinfo: do not report broken networks

phoracek at redhat.com phoracek at redhat.com
Wed Sep 24 10:33:43 UTC 2014


Petr Horáček has uploaded a new change for review.

Change subject: netinfo: do not report broken networks
......................................................................

netinfo: do not report broken networks

Function _getNetInfo() called from netinfo.py:get() raises IOError in
case when we try to get information about broken network (network with
non-existing interface).

In master branch we handle get() function differently, thanks to it
this error does not happen there.

I changed get() function to ignore IOError and not report that broken
network.

Change-Id: I1fa9173cb65d5140951c38d0cf1e49eb93222903
Signed-off-by: Petr Horáček <phoracek at redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/33320/1

diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index b1c0a90..1e09ed2 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -557,6 +557,8 @@
                                              netAttr.get('qosOutbound'))
         except KeyError:
             continue  # Do not report missing libvirt networks.
+        except IOError:
+            continue  # Do not report broken networks.
 
     for dev in (link for link in getLinks() if not link.isHidden()):
         if dev.isBRIDGE():


-- 
To view, visit http://gerrit.ovirt.org/33320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fa9173cb65d5140951c38d0cf1e49eb93222903
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>


More information about the vdsm-patches mailing list