Change in vdsm[ovirt-3.5]: gluster: Fix for build failure when with_gluster=0

dnarayan at redhat.com dnarayan at redhat.com
Wed Sep 24 08:36:05 UTC 2014


Hello Piotr Kliczewski, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/33313

to review the following change.

Change subject: gluster: Fix for build failure when with_gluster=0
......................................................................

gluster: Fix for build failure when with_gluster=0

Currently vdsmapi-gluster-schema.json file is not collected
by anything when built with_gluster=0, which is causing build
failure. Modified spec to exclude vdsmapi-gluster-schema.json
file when gluster is not enabled.

Change-Id: I0025365e367e4f1b294ec6439df90b7ed6538fb5
Signed-off-by: ndarshan <dnarayan at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33240
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/33313/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index ac8df22..e3e6f8b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1430,6 +1430,9 @@
 %{_datadir}/%{vdsm_name}/rpc/vdsmapi-schema.json
 %{python_sitelib}/vdsmapi.py*
 %{python_sitelib}/yajsonrpc/__init__.py*
+%if ! 0%{?with_gluster}
+%exclude %{_datadir}/%{vdsm_name}/rpc/vdsmapi-gluster-schema.json
+%endif
 
 %files yajsonrpc
 %dir %{python_sitelib}/yajsonrpc


-- 
To view, visit http://gerrit.ovirt.org/33313
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0025365e367e4f1b294ec6439df90b7ed6538fb5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>


More information about the vdsm-patches mailing list