Change in vdsm[master]: netinfo: Error out if we failed to change a bond's mode

osvoboda at redhat.com osvoboda at redhat.com
Tue Sep 23 12:54:48 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: Error out if we failed to change a bond's mode
......................................................................


Patch Set 3: Verified+1

(1 comment)

This patch makes the failure to read default bonding options very loud, as it should be.

 RuntimeError: ("Changing a bond's mode failed, is NetworkManager running?", '/usr/bin/tee: /sys/class/net/u9tWUEC5GhT7L41/bonding/mode: Operation not permitted')

is shown in vdsm.log when trying to run vdsClient -s 0 getVdsCaps. The command itself fails with a very unpleasant "Unexpected exception".

Unit test testGetBondingOptions fails when NM is running.

http://gerrit.ovirt.org/#/c/32657/3/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 311:             bonds.flush()
Line 312: 
Line 313:             try:
Line 314:                 with self.assertNotRaises():
Line 315:                     self.assertEqual(_getBondingOptions(bondName), {})
Changed from patch set 2: The function was made to raise RuntimeError in netinfo.py in this very patch.
Line 316: 
Line 317:                     with open(BONDING_OPT % (bondName, 'miimon'), 'w') as opt:
Line 318:                         opt.write(INTERVAL)
Line 319: 


-- 
To view, visit http://gerrit.ovirt.org/32657
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c29bd5aee13cd6f0be1ab7f308b5432f264215c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list