Change in vdsm[master]: fileSD: Move private constant near the only call site

Federico Simoncelli fsimonce at redhat.com
Mon Sep 22 08:59:26 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: fileSD: Move private constant near the only call site
......................................................................


Patch Set 1: Code-Review-1

Every time you use a (private) constant you would have to check if it was defined before/after the new code using it. It doesn't matter if it's private, it's still a constant for the module and you should be able to use it without moving it around.

-- 
To view, visit http://gerrit.ovirt.org/32724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8430a05dd454c34217bb051345633aec4351738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list