Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
ybronhei at redhat.com
ybronhei at redhat.com
Sun Sep 21 13:13:40 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................
Patch Set 9:
(5 comments)
http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 41: _CONFIGURATORS = dict((m.name, m) for m in (
Line 42: certificates.Certificates(),
Line 43: libvirt.Libvirt(),
Line 44: sanlock.Sanlock(),
Line 45: multipath.Multipath(),
you need to rebase again (http://gerrit.ovirt.org/31775)
Line 46: ))
Line 47:
Line 48:
Line 49: @expose("configure")
http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:
Line 62: "}\n"
Line 63: "}"
Line 64: )
Line 65:
Line 66: _MAX_CONF_COPIES = 5
MAX_OLD_CONF_FILES_COPY
Line 67:
Line 68: # conf file configured by vdsm should contain a tag
Line 69: # in form of "RHEV REVISION X.Y"
Line 70: _OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3",
Line 96: '''
: If multipathd is up, it will be reloaded after configuration,
: or started before vdsm starts, so service should not be stopped
: during configuration.
: '''
but if vdsm is up and we update the multipath version only, than we run vdsm-tool configure which will restart multipathd, don't we need to restart also vdsm?
Line 125: if utils.isOvirtNode():
Line 126: utils.persistFile(self._MPATH_CONF)
Line 127:
Line 128: # Flush all unused multipath device maps
Line 129: utils.execCmd([constants.EXT_MULTIPATH, "-F"])
don't you need to check the rc of this command?
Line 130:
Line 131: rc = service.service_reload("multipathd")
Line 132: if rc != 0:
Line 133: status = service.service_status("multipathd", False)
Line 169:
Line 170: for tag in self._OLD_TAGS:
Line 171: if tag in first:
Line 172: sys.stdout.write("Downrev multipath.conf detected, "
Line 173: "upgrade required\n")
Downrev? do you mean: old conf file is detected, please run "yum upgrade multipth" ?
Line 174: return NOT_CONFIGURED
Line 175:
Line 176: sys.stdout.write("multipath requires configuration\n")
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list