Change in vdsm[master]: libnl_wrapper: avoid getting link_cache just for getting ifa...

phoracek at redhat.com phoracek at redhat.com
Fri Sep 19 18:18:50 UTC 2014


Petr Horáček has posted comments on this change.

Change subject: libnl_wrapper: avoid getting link_cache just for getting iface label
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32949/2/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:

Line 140:         link = c_void_p()
Line 141:         if sock is None:
Line 142:             with _pool.socket() as sock:
Line 143:                 if name is None:
Line 144:                     err = _rtnl_link_get_kernel(sock, index, name, byref(link))
if name is None: use name

else: use name
Line 145:                 else:
Line 146:                     err = _rtnl_link_get_kernel(sock, index, name, byref(link))
Line 147:         else:
Line 148:             if name is None:


-- 
To view, visit http://gerrit.ovirt.org/32949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list