Change in vdsm[master]: libnl_wrapper: avoid getting link_cache just for getting ifa...

phoracek at redhat.com phoracek at redhat.com
Fri Sep 19 10:48:45 UTC 2014


Petr Horáček has posted comments on this change.

Change subject: libnl_wrapper: avoid getting link_cache just for getting iface label
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32949/1/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:

Line 34:         link = _get_link(sock, name)
Line 35:         if not link:
Line 36:             raise IOError(errno.ENODEV, '%s is not present in the system' %
Line 37:                           name)
Line 38:         return _link_info(cache, link)
you cannot use cache
Line 39: 
Line 40: 
Line 41: def iter_links():
Line 42:     """Generator that yields an information dictionary for each link of the


-- 
To view, visit http://gerrit.ovirt.org/32949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e6aaac0bdb58a0052b25f588e11de03bde3e12f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list