Change in vdsm[master]: make the promisc property compliant with old pyflakes

danken at redhat.com danken at redhat.com
Fri Sep 19 10:38:24 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: make the promisc property compliant with old pyflakes
......................................................................


make the promisc property compliant with old pyflakes

el6 pyflakes is older than the addition of setters and deleters for
python class properties. Thus, it wrongly detects the syntax:

    @x.setter
    def x(self, value)

As a redefinition of x. Thankfully, it is possible to use
the property builtin to achieve the same result without being
flagged as re-defining.

Change-Id: Ib44e44f12e15f6613cb9c841dc11938ab0ce9755
Bug-Url: https://bugzilla.redhat.com/1134851
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33071
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33071
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib44e44f12e15f6613cb9c841dc11938ab0ce9755
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list