Change in vdsm[master]: netlink: event monitor

danken at redhat.com danken at redhat.com
Thu Sep 18 15:05:35 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netlink: event monitor
......................................................................


Patch Set 13: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32626/13/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:

Line 21: import threading
Line 22: import time
Line 23: 
Line 24: from . import (
Line 25:                _KNOWN_GROUPS,
Please silence the silly pep8 errors:

/usr/bin/pep8 --version
1.5.6
for x in config.py constants.py crossImportsTests.py vdsm.py ; do \
    exclude="${exclude},${x}" ; \
done ; \
/usr/bin/pep8 --exclude="${exclude}" --filename '*.py,*.py.in' .
./lib/vdsm/netlink/monitor.py:25:16: E126 continuation line over-indented for hanging indent
./lib/vdsm/netlink/monitor.py:38:15: E126 continuation line over-indented for hanging indent
Line 26:                _NL_ROUTE_ADDR_NAME,
Line 27:                _NL_ROUTE_LINK_NAME,
Line 28:                _NL_ROUTE_NAME,
Line 29:                _NL_STOP,


-- 
To view, visit http://gerrit.ovirt.org/32626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list