Change in vdsm[master]: tool-tests: use variable from conf version in template files.

mtayer at redhat.com mtayer at redhat.com
Thu Sep 18 14:38:05 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool-tests: use variable from conf version in template files.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32713/1/tests/toolTests.py
File tests/toolTests.py:

Line 313:                         "rt") as fin:
Line 314:                     for line in fin:
Line 315:                         fout.write(line.replace(
Line 316:                             'CONF_VERSION',
Line 317:                             Libvirt.CONF_VERSION))
> Use Python standard templating:
OK, will change.

I also think CONF_VERSION better be LATEST_CONF_VERSION

(Since that's what the tests mean)

Can you please explain what you meant by:
"vdsm-%(CONF_VERSION)s"

Thanks
Line 318: 
Line 319:     def testValidatePositive(self):
Line 320:         libvirtConfigure = Libvirt()
Line 321: 


-- 
To view, visit http://gerrit.ovirt.org/32713
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list