Change in vdsm[master]: drop dead ksmtuned-related code

fromani at redhat.com fromani at redhat.com
Thu Sep 18 14:06:41 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: drop dead ksmtuned-related code
......................................................................


Patch Set 4: Verified+1

Verified using a patched VDSM against master.

Cluster was configured to
* enable KSM
* desktop optimization (share 200%)

Run 64 empty tiny (16 MB ram each) VM on the host, verified that relevant fields are present in the vdsClient output, that they are meaningful (e.g. ksmState = True) and that they change over time.

Also verified that the tunables under /sys change over time - when meaningful of course. From all the above I think is safe to infer that KSM is working through MOM as expected.

Some sample output:
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 0
	ksmPages = 100
	ksmState = False
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 0
	ksmPages = 100
	ksmState = False
[root at kenji ~]# systemctl restart vdsmd
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 0
	ksmPages = 100
	ksmState = False
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 0
	ksmPages = 100
	ksmState = False
[root at kenji ~]# vdsClient 0 getVdsCaps | less
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 7
	ksmPages = 64
	ksmState = True
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 2
	ksmPages = 64
	ksmState = True
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 2
	ksmPages = 64
	ksmState = True
[root at kenji ~]# cat /sys/kernel/
config/             fscache/            iommu_groups/       kexec_crash_size    mm/                 profiling           security/           uevent_helper       vmcoreinfo          
debug/              fscaps              kexec_crash_loaded  kexec_loaded        notes               rcu_expedited       slab/               uevent_seqnum       
[root at kenji ~]# cat /sys/kernel/
config/             fscache/            iommu_groups/       kexec_crash_size    mm/                 profiling           security/           uevent_helper       vmcoreinfo          
debug/              fscaps              kexec_crash_loaded  kexec_loaded        notes               rcu_expedited       slab/               uevent_seqnum       
[root at kenji ~]# cat /sys/kernel/mm/
hugepages/            ksm/                  transparent_hugepage/ 
[root at kenji ~]# cat /sys/kernel/mm/ksm/
full_scans          merge_across_nodes  pages_shared        pages_sharing       pages_to_scan       pages_unshared      pages_volatile      run                 sleep_millisecs     
[root at kenji ~]# cat /sys/kernel/mm/ksm/
full_scans          merge_across_nodes  pages_shared        pages_sharing       pages_to_scan       pages_unshared      pages_volatile      run                 sleep_millisecs     
[root at kenji ~]# cat /sys/kernel/mm/ksm/run 
1
[root at kenji ~]# cat /sys/kernel/mm/ksm/pages_shar
cat: /sys/kernel/mm/ksm/pages_shar: No such file or directory
[root at kenji ~]# cat /sys/kernel/mm/ksm/pages_sharing 
133031
[root at kenji ~]# cat /sys/kernel/mm/ksm/pages_to_scan 
64
[root at kenji ~]# cat /sys/kernel/mm/ksm/pages_shared
91
[root at kenji ~]# cat /sys/kernel/mm/ksm/pages_shared
90
[root at kenji ~]# cat /sys/kernel/mm/ksm/pages_shared
90
[root at kenji ~]# vdsClient 0 getVdsStats | grep ksm
	ksmCpu = 0
	ksmPages = 64
	ksmState = True
[root at kenji ~]#

-- 
To view, visit http://gerrit.ovirt.org/27026
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I511fa1754e55076084529834fa9758c2fd139761
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list