Change in vdsm[ovirt-3.4]: qemuimg: Create qcow2 compat 0.10 images

danken at redhat.com danken at redhat.com
Thu Sep 18 10:50:31 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: qemuimg: Create qcow2 compat 0.10 images
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33022/1/lib/vdsm/qemuImg.py
File lib/vdsm/qemuImg.py:

Line 118:     if rc != 0:
Line 119:         raise QImgError(rc, out, err)
Line 120: 
Line 121: 
Line 122: def _supports_qcow2_compat():
> no because if qemu-img is updated you're in trouble.
I don't expect a qemu-0.10 -> qemu-1.1 upgrade while Vdsm is running.

But we can live with this repetitive check for a while.
Line 123:     """
Line 124:     TODO: Remove this when qemu versions providing the "compat" option are
Line 125:     available on all platforms.
Line 126:     """


-- 
To view, visit http://gerrit.ovirt.org/33022
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list