Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

danken at redhat.com danken at redhat.com
Thu Sep 18 10:47:31 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Add a libvirt migration hook to filter out min_guarantee element
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/32928/6/vdsm/virt/libvirt-hook.sh
File vdsm/virt/libvirt-hook.sh:

Line 16: fi
Line 17: 
Line 18: # Fix VMs migrating to host with libvirt >= 1.2.8
Line 19: # See https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Line 20: exec sed -e 's|<min_guarantee[^>]*>[0-9 ]*</min_guarantee>||g'
> if it returns 1 and fail?
>From http://www.libvirt.org/hooks.html#qemu

"""
In case the script returns failure or the output XML is not valid, incoming migration will be canceled.
"""
which is what we want.


-- 
To view, visit http://gerrit.ovirt.org/32928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list