Change in vdsm[master]: pyroute2: IPv6 support

asegurap at redhat.com asegurap at redhat.com
Thu Sep 18 10:08:50 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: pyroute2: IPv6 support
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/32033/4/vdsm/network/configurators/pyroute_two.py
File vdsm/network/configurators/pyroute_two.py:

Line 69:             with self.ip.interfaces[iface.name] as i:
Line 70:                 i.add_ip(ipConfig.ipv6addr)
Line 71:             if ipConfig.ipv6gateway:
Line 72:                 self.ip.routes.add({'dst': 'default',
Line 73:                                     'gateway': ipConfig.ipv6gateway}).commit()
I would have preferred explicit family setting, but pyroute2 autodetects, so it is fine.
Line 74:         if ipConfig.ipv6autoconf is not None:
Line 75:             with open('/proc/sys/net/ipv6/conf/%s/autoconf' % iface.name,
Line 76:                       'w') as ipv6_autoconf:
Line 77:                 ipv6_autoconf.write('1' if ipConfig.ipv6autoconf else '0')


-- 
To view, visit http://gerrit.ovirt.org/32033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list