Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...

msivak at redhat.com msivak at redhat.com
Thu Sep 18 08:06:11 UTC 2014


Martin Sivák has posted comments on this change.

Change subject: Add a libvirt migration hook to filter out min_guarantee element
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/32928/4/vdsm/virt/libvirt-hook.sh
File vdsm/virt/libvirt-hook.sh:

Line 5: 
Line 6: # This condition depends on a feature that will be included in
Line 7: # libvirt once https://bugzilla.redhat.com/show_bug.cgi?id=1142684
Line 8: # is resolved. It will work only for migrations before that.
Line 9: if [ "x$EVENT" != "xmigrate" -a "x$EVENT" != "xrestore" ]; then
> Why do you need the "x"?
If we rely on libvirt implementation, then I probably don't. Otherwise it prevents test from being confused by input with - at the beginning that could be evaluated as an option (-n, -z, -a, ...) instead of a value. And it works on old shells with broken test command.. but those are not really relevant for us anymore.

It is just hardwired to my brain, I have used it for about 15 years now.
Line 10:   exit 0
Line 11: fi
Line 12: 
Line 13: # Fix VMs migrating to host with libvirt >= 1.2.8


-- 
To view, visit http://gerrit.ovirt.org/32928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list