Change in vdsm[master]: gluster: Fix for json-rpc issue wrt gluster commands.

dnarayan at redhat.com dnarayan at redhat.com
Thu Sep 18 07:01:38 UTC 2014


Darshan N has posted comments on this change.

Change subject: gluster: Fix for json-rpc issue wrt gluster commands.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33007/1/vdsm/rpc/vdsmapi.py
File vdsm/rpc/vdsmapi.py:

Line 123: 
Line 124:     localpath = os.path.dirname(__file__)
Line 125: 
Line 126:     if schema_name == 'vdsmapi-gluster':
Line 127:         installedpath = constants.P_VDSM_GLUSTER
> it seems so much cleaner to place vdsmapi-gluster-schema.json under /usr/sh
ya, Will move it to vdsm/rpc/ .
Line 128:     else:
Line 129:         installedpath = constants.P_VDSM_RPC
Line 130: 
Line 131:     for directory in localpath, installedpath:


-- 
To view, visit http://gerrit.ovirt.org/33007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list