Change in vdsm[master]: Configure iSCSI iface.net_ifacename

asegurap at redhat.com asegurap at redhat.com
Wed Sep 17 18:33:05 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: Configure iSCSI iface.net_ifacename
......................................................................


Patch Set 13: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 106:         - iSCSI host path - e.g. '/sys/class/iscsi_host/host17/'
Line 107:     """
Line 108: 
Line 109:     pattern = '/sys/devices/platform/host*/session%s' % sessionID
Line 110:     for path in glob.glob(pattern):
better use iglob
Line 111:         host = os.path.basename(os.path.dirname(path))
Line 112:         return '/sys/class/iscsi_host/' + host
Line 113: 
Line 114:     raise OSError(errno.ENOENT, "No iscsi_host for session [%s]" % sessionID)


Line 152:         username = None
Line 153:     if password in ["<NULL>", "(null)"]:
Line 154:         password = None
Line 155: 
Line 156:     if netdev in ["<NULL>", "(null)"]:
tuple instead of list ('<Null>', '(null)')
Line 157:         netdev = None
Line 158: 
Line 159:     iface = IscsiInterface(iface, netIfacename=netdev)
Line 160:     portal = IscsiPortal(ip, port)


-- 
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list