Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
msivak at redhat.com
msivak at redhat.com
Wed Sep 17 13:22:49 UTC 2014
Martin Sivák has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/32928/3//COMMIT_MSG
Commit Message:
Line 4: Commit: Martin Sivak <msivak at redhat.com>
Line 5: CommitDate: 2014-09-16 16:55:47 +0200
Line 6:
Line 7: Add a libvirt migration hook to filter out min_guarantee element
Line 8:
> Please explain why a change is needed. A bug url is not a replacement for c
Done
Line 9: Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
http://gerrit.ovirt.org/#/c/32928/3/vdsm/virt/libvirt-hook.sh
File vdsm/virt/libvirt-hook.sh:
Line 2: DOMAIN=$1
Line 3: EVENT=$2
Line 4: PHASE=$3
Line 5:
Line 6: if [ ! "x$EVENT" == "xmigrate" ]; then
> Why not the simpler and clear:
Done
Line 7: exit 0
Line 8: fi
Line 9:
Line 10: # Fix VMs migrating to host with libvirt >= 1.2.8
--
To view, visit http://gerrit.ovirt.org/32928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list