Change in vdsm[master]: network/api.py: delete network's orphans + test

danken at redhat.com danken at redhat.com
Wed Sep 17 12:07:40 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: network/api.py: delete network's orphans + test
......................................................................


network/api.py: delete network's orphans + test

When addNetwork fails on ifup, it leaves orphan devices.

setupNetworks function is changed to remove leftovers in case of
addNetwork's ConfigNetworkError with code ERR_FAILED_IFUP.

testHonorBlockingDhcp tests for bridge leftovers.
testNetworksEmergencyDevicesCleanup tests for leftovers of more
complex network which overwrites existing devices.

Two/four added tests takes almost five minutes so they (and
testHonorBlockingDhcp) are marked as @slowtest.

Change-Id: I3ef7ab74a53a8c2bd49710c01771b623c41cbf88
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31336
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M vdsm/network/api.py
2 files changed, 99 insertions(+), 4 deletions(-)

Approvals:
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef7ab74a53a8c2bd49710c01771b623c41cbf88
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list