Change in vdsm[master]: tests: split tests fakes in a module

danken at redhat.com danken at redhat.com
Wed Sep 17 11:42:29 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: split tests fakes in a module
......................................................................


tests: split tests fakes in a module

For the VM tests, we gathered a fair amount of Fake
helper objects. Is time to move them in a module,
in order to make it simpler for the other tests
to use them, and also to avoid to vmTests.py
become another vm.py, before it's too late.

Code changes are limited to renaming
* for better clarity; or
* to avoid redundancy or name clashing.

Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32650
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/Makefile.am
M tests/numaUtilsTests.py
M tests/vmApiTests.py
M tests/vmTests.py
M tests/vmXmlTests.py
A tests/vmfakelib.py
6 files changed, 311 insertions(+), 272 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/32650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list