Change in vdsm[master]: Configure iSCSI iface.net_ifacename

nsoffer at redhat.com nsoffer at redhat.com
Wed Sep 17 10:08:28 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Configure iSCSI iface.net_ifacename
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 401:         self._conf = conf
Line 402: 
Line 403:     def __repr__(self):
Line 404:         return "<IscsiInterface name='%s' transport='%s' netIfacename='%s'>" \
Line 405:             % (self.name, self.transport, self.netIfacename)
In the ISCSIInterface, name and netifacename looks wrong. What is the different between two values?

Wouldn't it be simpler to keep the name "netdev" used by sysfs, and have self.name and self.netdev?
Line 406: 
Line 407: 
Line 408: def iterateIscsiInterfaces():
Line 409:     names = iscsiadm.iface_list()


-- 
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list