Change in vdsm[master]: jsonrpc: sslerror during accept should be logged on warning

danken at redhat.com danken at redhat.com
Tue Sep 16 19:49:41 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: sslerror during accept should be logged on warning
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32985/2/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:

Line 176:         try:
Line 177:             client_socket, _ = self._socket.accept()
Line 178:         except SSL.SSLError as e:
Line 179:             self.log.warning("Unable to accept connection due to %s", e)
Line 180: 
But client_socket is undefined in case of error. add_connection should sit under an "else" clause.

It seems that this was not verified as carefully as ps1.
Line 181:         self._add_connection(client_socket)
Line 182: 
Line 183:     def _add_connection(self, socket):
Line 184:         host, port = socket.getpeername()


-- 
To view, visit http://gerrit.ovirt.org/32985
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44e6131fb50464a18502ff98829a124903f3ca8b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list