Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor

ybronhei at redhat.com ybronhei at redhat.com
Tue Sep 16 13:15:24 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: jsonrpc: wrong usage of optional arguments in ctor
......................................................................


jsonrpc: wrong usage of optional arguments in ctor

When ctor arguments are marked as optional in schema the code compares
argument names with '*' from schema with request names without '*'.
This behavior result in passing wrong number of arguments to a method.


Bug-Url: https://bugzilla.redhat.com/1141510
Change-Id: I3630025b992e3ec8573069c5868c415653515594
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/32980
Reviewed-by: Oved Ourfali <oourfali at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/rpc/Bridge.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/32980
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list