Change in vdsm[master]: jsonrpc: sslerror during accept should be logged on warning
nsoffer at redhat.com
nsoffer at redhat.com
Tue Sep 16 13:04:14 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32985/1/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 97: except _Stopped:
Line 98: break
Line 99: except SSL.SSLError as e:
Line 100: self.log.warning("Unable to accept connection due to %s",
Line 101: e)
This is not the place to handle this - you don't have any idea where the SSLError case from here.
This should be around the line that invoke self._socket.accept()
Line 102: except Exception:
Line 103: self.log.exception("Unhandled exception")
Line 104: finally:
Line 105: self._cleanup()
--
To view, visit http://gerrit.ovirt.org/32985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e6131fb50464a18502ff98829a124903f3ca8b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list