Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 16 13:01:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: jsonrpc: wrong usage of optional arguments in ctor
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/32980/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 152:         for arg in allArgs:
Line 153:             name = self._symNameFilter(arg)
Line 154: 
Line 155:             if name not in ctorArgs:
Line 156:                 methodArgs.append(arg)
This should work, but note that this appends "*name" to methodArgs, and in _getArgs "*name" is converted again to "name".

This mess should be cleaned later.
Line 157: 
Line 158:         return self._getArgs(argObj, methodArgs, defaultArgs)
Line 159: 
Line 160:     def _getDefaultArgs(self, api, className, methodName):


-- 
To view, visit http://gerrit.ovirt.org/32980
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list