Change in vdsm[master]: test: fix typos and repair vmTests

fromani at redhat.com fromani at redhat.com
Tue Sep 16 11:14:51 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: test: fix typos and repair vmTests
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py
File tests/vmTests.py:

Line 1311:                     }
Line 1312:                 },
Line 1313:                 log=self.log,
Line 1314:                 index=0,
Line 1315:                 device="disk",
> Why does it matter?
because otherwise the test will fail. in Vm.sdIds we have

 if device['device'] == 'disk'
Line 1316:                 path="/dev/dummy",
Line 1317:                 type=vm.DISK_DEVICES,
Line 1318:                 iface="ide",
Line 1319:                 domainID=domainID,


Line 1342:         with FakeVM() as machine:
Line 1343:             for drive in drives:
Line 1344:                 machine._devices[drive.type].append(drive)
Line 1345: 
Line 1346:             self.assertEqual(machine.sdIds, set([domainID]))
> This was fixed here: http://gerrit.ovirt.org/#/c/32796/6..7/tests/vmTests.p
Yep. Looks like some bits got lost in a rebase.
Line 1347: 
Line 1348:     def testGetUnderlyingGraphicsDeviceInfo(self):
Line 1349:         port = '6000'
Line 1350:         tlsPort = '6001'


-- 
To view, visit http://gerrit.ovirt.org/32965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7af4632921b84ae4376a64c0ee45e4393030cd97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list