Change in vdsm[master]: tests: Use more clear name

danken at redhat.com danken at redhat.com
Tue Sep 16 09:22:25 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Use more clear name
......................................................................


tests: Use more clear name

false_mock is misterious name, specially when used as false_mock=False.
Reading the code reveal that false_mock=True means that the mock should
fail. Hopefully renming it to should_fail will make this more clear.

When creating a mock, using optional argument notation "should_fail=True"
is more clear then just "True".

Change-Id: I0697923fb18eb0d7d35e8044da7f6b4f8ee9d051
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32726
Reviewed-by: mooli tayer <mtayer at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/toolTests.py
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Nir Soffer: Verified
  mooli tayer: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0697923fb18eb0d7d35e8044da7f6b4f8ee9d051
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list