Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

emesika at redhat.com emesika at redhat.com
Tue Sep 16 08:13:28 UTC 2014


Eli Mesika has posted comments on this change.

Change subject: vdsm: making PM 'on' and 'off' sync
......................................................................


Patch Set 3: -Verified

(1 comment)

http://gerrit.ovirt.org/#/c/32695/3/vdsm/API.py
File vdsm/API.py:

Line 1253:                 message = out + err
Line 1254:             ret = {'status': {'code': rc, 'message': message},
Line 1255:                    'power': 'unknown'}
Line 1256: 
Line 1257:         return ret
> Eli, 'operationStatus': 'initiated' has to be contained in return value, ot
So

else:

...
   ret = {'status': {'code': rc, 'message': message},
          'power': 'unknown', 'operationStatus': 'initiated'}


Is that OK ?
Line 1258: 
Line 1259:     def ping(self):
Line 1260:         "Ping the server. Useful for tests"
Line 1261:         updateTimestamp()


-- 
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list