Change in vdsm[master]: jsonrpc: wrong usage of optional arguments in ctor

amureini at redhat.com amureini at redhat.com
Tue Sep 16 07:57:47 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: jsonrpc: wrong usage of optional arguments in ctor
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32964/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 152:         for arg in allArgs:
Line 153:             if arg.startswith('*'):
Line 154:                 name = self._symNameFilter(arg)
Line 155:             else:
Line 156:                 name = arg
_symNameFilter already does the check of startsWith('*'). 
So, the only thing you'll need is 

    name = _sumNameFilter(arg)

(without the if-else block)
Line 157: 
Line 158:             if name not in ctorArgs:
Line 159:                 methodArgs.append(arg)
Line 160: 


-- 
To view, visit http://gerrit.ovirt.org/32964
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list