Change in vdsm[master]: vm: implement VM.sdIds as read-only property

danken at redhat.com danken at redhat.com
Mon Sep 15 21:56:48 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: implement VM.sdIds as read-only property
......................................................................


vm: implement VM.sdIds as read-only property

Changed the VM object sdIds list attribute. It used to be a list that
kept a copy of the storage domains in use in an additional list (with
all the difficulties of keeping the list in sync). That list has been
replaced with a property that returns the storage domains in use
getting them directly from the the vm devices in use.

Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Relates-To: https://bugzilla.redhat.com/1094518
Signed-off-by: Fabio Pliger <fabio.pliger at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/32796
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 69 insertions(+), 23 deletions(-)

Approvals:
  Fabio Pliger: Verified; Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list