Change in vdsm[master]: vm: return diskMapping on status()

nsoffer at redhat.com nsoffer at redhat.com
Mon Sep 15 19:41:58 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: return diskMapping on status()
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/31700/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2433:     def status(self):
Line 2434:         # used by API.Global.getVMList
Line 2435:         self.conf['status'] = self.lastStatus
Line 2436:         # Filter out any internal keys
Line 2437:         d = dict((k, v) for k, v in self.conf.iteritems()
> Not a fan of single-letter identifiers (despite my past C experience). Coul
"status" would nice.
Line 2438:                  if not k.startswith("_"))
Line 2439:         d['guestDiskMapping'] = self.guestAgent.guestDiskMapping
Line 2440:         return d
Line 2441: 


-- 
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list