Change in vdsm[master]: virt: move general devices to vmdevices
fromani at redhat.com
fromani at redhat.com
Mon Sep 15 15:48:18 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: virt: move general devices to vmdevices
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Let's use
vmdevices.Generic
which seems nicer to me
http://gerrit.ovirt.org/#/c/32294/3/vdsm/virt/vmdevices.py
File vdsm/virt/vmdevices.py:
Line 44: if not a.startswith('__')]
Line 45: return ' '.join(attrs)
Line 46:
Line 47:
Line 48: class GeneralDevice(Base):
s/GeneralDevice/Generic/
Line 49:
Line 50: def getXML(self):
Line 51: """
Line 52: Create domxml for general device
Line 48: class GeneralDevice(Base):
Line 49:
Line 50: def getXML(self):
Line 51: """
Line 52: Create domxml for general device
s/general/generic/
Line 53: """
Line 54: return self.createXmlElem(self.type, self.device, ['address'])
Line 55:
Line 56:
--
To view, visit http://gerrit.ovirt.org/32294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a904346d7ef3b4f3a89e68030e44e21377b7645
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list