Change in vdsm[master]: virt: move sound device to vmdevices
fromani at redhat.com
fromani at redhat.com
Mon Sep 15 15:47:17 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: virt: move sound device to vmdevices
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
some rebase glitches sneaked into.
Besides that, let's take this chance to find a nicer name.
http://gerrit.ovirt.org/#/c/29265/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1388: # limit threads number until the libvirt lock will be fixed
Line 1389: _ongoingCreations = threading.BoundedSemaphore(4)
Line 1390: DeviceMapping = ((DISK_DEVICES, Drive),
Line 1391: (NIC_DEVICES, NetworkInterfaceDevice),
Line 1392: <<<<<<< HEAD
rebase glitch
Line 1393: (SOUND_DEVICES, SoundDevice),
Line 1394: (VIDEO_DEVICES, vmdevices.VideoDevice),
Line 1395: =======
Line 1396: (SOUND_DEVICES, vmdevices.SoundDevice),
http://gerrit.ovirt.org/#/c/29265/5/vdsm/virt/vmdevices.py
File vdsm/virt/vmdevices.py:
Line 70: video.appendChildWithArgs('model', type=self.device, **sourceAttrs)
Line 71: return video
Line 72:
Line 73:
Line 74: class SoundDevice(Base):
Let's get rid of 'Device', because
vmdevices.SoundDevice
feels redundant.
Let's just rename this 'Sound'. If you have a better name, just go ahead.
Line 75: __slots__ = ('address', 'alias')
Line 76:
Line 77: def getXML(self):
Line 78: """
--
To view, visit http://gerrit.ovirt.org/29265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42b8ae3475373d39c7d6375ccbc23a85437e19d0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list