Change in vdsm[master]: virt: move controller device to vmdevices.py
fromani at redhat.com
fromani at redhat.com
Mon Sep 15 15:35:14 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: virt: move controller device to vmdevices.py
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Let's kill some repeated 'device'. Other than that, fine for me.
-1 for visibility
http://gerrit.ovirt.org/#/c/29261/3/vdsm/virt/vmdevices.py
File vdsm/virt/vmdevices.py:
Line 44: if not a.startswith('__')]
Line 45: return ' '.join(attrs)
Line 46:
Line 47:
Line 48: class ControllerDevice(Base):
Let's take this chance to rename this 'Controller', or anything you find better.
But we should remove the 'Device' redundancy:
vmdevices.ControllerDevice
:)
Line 49: __slots__ = ('address', 'model', 'index', 'master')
Line 50:
Line 51: def getXML(self):
Line 52: """
--
To view, visit http://gerrit.ovirt.org/29261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I941a76230fd5cc3c28495c5fa8526f8735bb51ef
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list