Change in vdsm[master]: tests: split tests fakes in a module

fromani at redhat.com fromani at redhat.com
Mon Sep 15 12:46:03 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: tests: split tests fakes in a module
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/32650/3/tests/vmApiTests.py
File tests/vmApiTests.py:

Line 64: 
Line 65: 
Line 66: class TestVmStats(TestSchemaCompliancyBase):
Line 67:     def testDownStats(self):
Line 68:         with fake.VM() as testvm:
> Why not simply "vm"?
I have only this poor excuse for my choice of naming: forward comapbility. The day we'll need to do

  from virt import vm

we'll need to change all the names.

It is not so unlikely we'll need to import the vm module here, but on the other hand is not planned yet either.
Line 69:             testvm.setDownStatus(define.ERROR, vmexitreason.GENERIC_ERROR)
Line 70:             self.assertVmStatsSchemaCompliancy('ExitedVmStats',
Line 71:                                                testvm.getStats())
Line 72: 


-- 
To view, visit http://gerrit.ovirt.org/32650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list