Change in vdsm[master]: vm: implement VM.sdIds as read-only property

fromani at redhat.com fromani at redhat.com
Mon Sep 15 12:22:46 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: implement VM.sdIds as read-only property
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2872
Line 2873
Line 2874
Line 2875
Line 2876
> should I wait for a confirmation on this before resending the patch?
I'd do the following:

- amend the comment to read like

   # In the recovery flow we do not start disk stats collection here
   # since irs may not be ready yet. 

  (the rest follows unchanged)

- de-indent the comment block of one level, put it at the same level of the above if:

   if not self.recovering:
       # code unchanged
   # In the recovery flow...

This is IMO the simplest modification which makes sense.


-- 
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list