Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
asegurap at redhat.com
asegurap at redhat.com
Mon Sep 15 12:16:40 UTC 2014
Antoni Segura Puimedon has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/31529/14/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 357: @logDecorator
Line 358: def sysctlCmd(self, key, value):
Line 359: option = '='.join([key, value])
Line 360: cmd = [_SYSCTL_BINARY.cmd, '-w', option]
Line 361: rc, out, err = utils.execCmd(cmd)
Instead of starting a process like sysctl, I think it'd be best to use the newer and preferred interface of file access to /proc/sys/
for example you have:
/proc/sys/net/ipv4/conf/default/arp_ignore
Line 362: if rc:
Line 363: self.log.error("Sysctl -w command failed rc=%s, "
Line 364: "out=\"%s\", err=\"%s\"", rc, out, err)
Line 365: raise OSError(errno.EINVAL, "Could not set sysctl option "
--
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list