Change in vdsm[master]: vm: implement VM.sdIds as read-only property
danken at redhat.com
danken at redhat.com
Mon Sep 15 09:15:10 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vm: implement VM.sdIds as read-only property
......................................................................
Patch Set 7: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2872
Line 2873
Line 2874
Line 2875
Line 2876
this comment is unrelated to sdIds maintenance - please keep it. It was added very recently.
Line 5588: def sdIds(self):
Line 5589: """
Line 5590: Returns a list of the ids of the storage domains in use by the VM.
Line 5591: """
Line 5592: return set(device.domainID for device in self._devices[DISK_DEVICES]
The removed code had an additional check for
drive['device'] == 'disk'
I do not think it was correct - ISO domains should have been accounted for. However, this change extend from mere refactoring. Please confirm in the commit message that it was intentional; placing it in its own patch makes sense, too.
Line 5593: if isVdsmImage(device))
Line 5594:
Line 5595:
Line 5596: class LiveMergeCleanupThread(threading.Thread):
--
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list