Change in vdsm[master]: vm: migration: exponential downtime increment

mpolednik at redhat.com mpolednik at redhat.com
Mon Sep 15 08:41:29 UTC 2014


Martin Polednik has posted comments on this change.

Change subject: vm: migration: exponential downtime increment
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

Seems correct to me, +1 for patches (to think: run tests against multiple sets of (downtime, steps) in order to be really sure the properties hold still or support a proof ;))

http://gerrit.ovirt.org/#/c/25820/7/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 358:     offset = downtime / steps
Line 359:     base = (downtime - offset) ** (1 / float(steps))
Line 360: 
Line 361:     for i in range(1, steps+1):
Line 362:         yield offset + int(base ** i)
Minor: I'd go with yield int(offset + base ** i) in order to guarantee the return value being int even if downtime ∈ ℝ(really minor imho, I'd guess that might destroy something else)
Line 363: 
Line 364: 
Line 365: class DowntimeThread(threading.Thread):
Line 366:     DOWNTIME_STEPS = config.getint('vars', 'migration_downtime_steps')


-- 
To view, visit http://gerrit.ovirt.org/25820
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list